Forcer l'unicité du data_pass_id #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
approved these changes
Mar 21, 2022
mrjmad
approved these changes
Mar 21, 2022
mrjmad
force-pushed
the
ahr/unique-data-pass-id
branch
from
ecc9b62
to
37f9db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌮 Objectif
Empêcher les doublons des identifiants datapass,
🔍 Implémentation
Il faut nettoyer la base de prod (peut-être aussi de préprod) avant de déployer pour supprimer les doublons de datapass_id
Bug identifié : le champ "datapass_id" n'est pas modifiable si on essaie par mégarde de modifier une organisation sans id pour lui mettre un id déjà assigné à quelqu'un d'autre (pas de problème dans le cas d'une création)
-> Mais à terme on voudrait éviter aux humains de choisir manuellement des identifiants, donc pour l'instant on ne met pas trop de sueur dans ce souci particulier🖼️ Images
Quand on veut créer une organisation en lui donnant un datapass_id existant :